Make balance search use async - #6
Open
SachinMeier wants to merge 1 commit into
Open
SachinMeier wants to merge 1 commit into
SachinMeier wants to merge 1 commit into
Conversation
SachinMeier
force-pushed
the
sachin--speed-up-balance-finding-using-async
branch
from
September 23, 2024 18:14
54590f2 to
51a0e87
Compare
SachinMeier
commented
Sep 23, 2024
Comment on lines
+148
to
154
| left_task = | ||
| Task.async(fn -> do_find_balances_for_accounts(left_leaves, leaf_idx, account_balances) end) | ||
|
|
||
| right_task = | ||
| Task.async(fn -> | ||
| do_find_balances_for_accounts(right_leaves, leaf_idx + mid_idx, account_balances) | ||
| end) |
Contributor
Author
There was a problem hiding this comment.
This logic can easily run into the max number of beam processes. Does that make this not the right solution?
One option is an explicit conditional to use async or sequential searches depending on the number of leaves.
|
``git clone https://github.com/RiverFinancial/proof-of-reserves.git cd proof-of-reserves ./scripts/setup.sh source "$HOME/.asdf/asdf.sh" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the logic for finding balances for accounts to be faster.